Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: constrain numpy #133

Merged
merged 1 commit into from
Feb 13, 2024
Merged

infra: constrain numpy #133

merged 1 commit into from
Feb 13, 2024

Conversation

AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d40152d) 100.00% compared to head (28a0777) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1028      1028           
  Branches       181       181           
=========================================
  Hits          1028      1028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull marked this pull request as ready for review February 13, 2024 00:24
Copy link
Member

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a GitHub issue that explains why the tests fail with newer numpy versions? If so, can you mention it here?

@AbeCoull
Copy link
Contributor Author

Is there a GitHub issue that explains why the tests fail with newer numpy versions? If so, can you mention it here?

There is numpy/numpy#25809 open but so far I have not found the rca from log diving.

@AbeCoull AbeCoull merged commit 67ac8e5 into main Feb 13, 2024
13 checks passed
@AbeCoull AbeCoull deleted the math411-patch-2 branch February 13, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants