Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Move Quasar out to a new package #60

Merged
merged 1 commit into from
Oct 28, 2024
Merged

change: Move Quasar out to a new package #60

merged 1 commit into from
Oct 28, 2024

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Move Quasar parsing code for OQ3 into its own package to keep this package focused on the simulation portion

Testing done: Unit tests passed locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner October 18, 2024 15:45
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (c813a10) to head (5941f49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/custom_gates.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   98.91%   98.26%   -0.65%     
==========================================
  Files          23       21       -2     
  Lines        3495     2189    -1306     
==========================================
- Hits         3457     2151    -1306     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws merged commit 42a9214 into main Oct 28, 2024
15 of 17 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/quasout branch October 28, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants