This repository has been archived by the owner on Feb 7, 2018. It is now read-only.
Proposed 2.0.5 Release #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ttl column for dynamodb TTL support. Default functionality is the Reaper will still execute even if TTL support is added to the table. Added the flexibility to disable the reaper though the properties files in the resources directory. Added debug messages. Will be added maven profiles for tomcat 7 vs 8.
…embedded tomcat versions. Refactored TomcatUtils not to loop. Refactored DynamoDBSessionManager to retain a handle to the Context object, to limit the amount of reflection done.
…e. Added constructor parameters or setter methods to avoid duplication of static setting values in classes. Removed Unit test that no longer was applicable. There is a boolean value to disable the Reaper. My vision is that users that are using TTL don't need the reaper to be running; so ignore it completely. The TTL process on dynamodb will be acting as the Reaper in that case. For TTL the column is added, but the management of TTL still needs to occur through the AWS admin console.
…. Removed final from variables that can be modified by the app server.
|
Seems like most of the failures are env related. I've compile and tested successfully against tomcat 7.0.59. |
… be saved after Tomcat shutdown.
|
This project has been archived. Please see the README.md for more detail on alternative projects. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main premise was to add a column to the session dynamodb table to enable TTL on. I also added the flexibility to disable the Reaper as TTL will be preforming sweeps of the table for expired sessions. I also added support, through reflection, to allow the code base to work for Tomcat 7 & 8. Maven profiles were created for integration testing of either tomcat version. Lastly, I moved all the static default values to a properties file that is packaged in the jar file. The was removing duplicate static string values and in general makes for easier configuration.