Skip to content

fix(server): 🐛 Fix IDR resend logic (#2403) #4345

fix(server): 🐛 Fix IDR resend logic (#2403)

fix(server): 🐛 Fix IDR resend logic (#2403) #4345

GitHub Actions / clippy succeeded Oct 5, 2024 in 0s

clippy

31 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 31
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cda 2024-09-04)

Annotations

Check warning on line 8 in alvr\dashboard\src\dashboard\components\settings_controls\notice.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `notice` is never used

warning: function `notice` is never used
 --> alvr\dashboard\src\dashboard\components\settings_controls\notice.rs:8:8
  |
8 | pub fn notice(ui: &mut Ui, text: &str) {
  |        ^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

Check warning on line 22 in alvr\dashboard\src\dashboard\components\settings_controls\up_down.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `eframe::egui::Ui::add_visible_ui`: Use 'ui.scope_builder' instead

warning: use of deprecated method `eframe::egui::Ui::add_visible_ui`: Use 'ui.scope_builder' instead
  --> alvr\dashboard\src\dashboard\components\settings_controls\up_down.rs:22:14
   |
22 |             .add_visible_ui(index < count - 1, |ui| ui.small_button("⬇"))
   |              ^^^^^^^^^^^^^^

Check warning on line 18 in alvr\dashboard\src\dashboard\components\settings_controls\up_down.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `eframe::egui::Ui::add_visible_ui`: Use 'ui.scope_builder' instead

warning: use of deprecated method `eframe::egui::Ui::add_visible_ui`: Use 'ui.scope_builder' instead
  --> alvr\dashboard\src\dashboard\components\settings_controls\up_down.rs:18:14
   |
18 |             .add_visible_ui(index > 0, |ui| ui.small_button("⬆"))
   |              ^^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

Check warning on line 437 in alvr\client_openxr\src\interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\client_openxr\src\interaction.rs:437:13
    |
437 |             &reference_space,
    |             ^^^^^^^^^^^^^^^^ help: change this to: `reference_space`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 423 in alvr\client_openxr\src\interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr\client_openxr\src\interaction.rs:423:17
    |
423 |         .relate(&reference_space, time)
    |                 ^^^^^^^^^^^^^^^^ help: change this to: `reference_space`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 28 in alvr\client_openxr\src\interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `aim_action` and `aim_space` are never read

warning: fields `aim_action` and `aim_space` are never read
  --> alvr\client_openxr\src\interaction.rs:28:9
   |
24 | pub struct HandInteraction {
   |            --------------- fields in this struct
...
28 |     pub aim_action: xr::Action<xr::Posef>,
   |         ^^^^^^^^^^
29 |     pub aim_space: xr::Space,
   |         ^^^^^^^^^

Check warning on line 90 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `system` is never read

warning: field `system` is never read
  --> alvr\client_openxr\src\lib.rs:90:5
   |
88 | pub struct XrContext {
   |            --------- field in this struct
89 |     instance: xr::Instance,
90 |     system: xr::SystemId,
   |     ^^^^^^
   |
   = note: `XrContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 193 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr\client_openxr\src\lib.rs:193:9
    |
193 |     let mut parsed_stream_config = None::<ParsedStreamConfig>;
    |         ----^^^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`

Check warning on line 192 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr\client_openxr\src\lib.rs:192:9
    |
192 |     let mut last_lobby_message = String::new();
    |         ----^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 205 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_stream`

warning: unused variable: `xr_frame_stream`
   --> alvr\client_openxr\src\lib.rs:205:51
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                                                   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

Check warning on line 205 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_waiter`

warning: unused variable: `xr_frame_waiter`
   --> alvr\client_openxr\src\lib.rs:205:30
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                              ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

Check warning on line 205 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_session`

warning: unused variable: `xr_session`
   --> alvr\client_openxr\src\lib.rs:205:14
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |              ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

Check warning on line 193 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `parsed_stream_config`

warning: unused variable: `parsed_stream_config`
   --> alvr\client_openxr\src\lib.rs:193:13
    |
193 |     let mut parsed_stream_config = None::<ParsedStreamConfig>;
    |             ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parsed_stream_config`

Check warning on line 192 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `last_lobby_message`

warning: unused variable: `last_lobby_message`
   --> alvr\client_openxr\src\lib.rs:192:13
    |
192 |     let mut last_lobby_message = String::new();
    |             ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 211 in alvr\client_openxr\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable definition

warning: unreachable definition
   --> alvr\client_openxr\src\lib.rs:211:13
    |
207 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ------------------------------------------------ any code following this expression is unreachable
...
211 |         let xr_context = XrContext {
    |             ^^^^^^^^^^ unreachable definition
    |
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
   --> alvr\client_openxr\src\lib.rs:207:45
    |
207 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(unreachable_code)]` on by default

Check warning on line 133 in alvr\server_core\src\bitrate.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`f32` -> `f32`)

warning: casting to the same type is unnecessary (`f32` -> `f32`)
   --> alvr\server_core\src\bitrate.rs:133:25
    |
133 |                         self.packet_bytes_average.get_average() as f32,
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 14 in alvr\client_openxr\src\interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `time::Duration`

warning: unused import: `time::Duration`
  --> alvr\client_openxr\src\interaction.rs:14:33
   |
14 | use std::{collections::HashMap, time::Duration};
   |                                 ^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 158 in alvr\client_mock\src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `ViewParams` which implements the `Copy` trait

warning: using `clone` on type `ViewParams` which implements the `Copy` trait
   --> alvr\client_mock\src/main.rs:158:31
    |
158 |     context.send_view_params([views_params.clone(), views_params]);
    |                               ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 370 in alvr\client_core\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
   --> alvr\client_core\src\lib.rs:370:9
    |
359 | /         let view_params = [
360 | |             ViewParams {
361 | |                 pose: head_pose * view_params[0].pose,
362 | |                 fov: view_params[0].fov,
...   |
367 | |             },
368 | |         ];
    | |__________- unnecessary `let` binding
369 |
370 |           view_params
    |           ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
    = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
    |
359 ~         
360 |
361 ~         [
362 +             ViewParams {
363 +                 pose: head_pose * view_params[0].pose,
364 +                 fov: view_params[0].fov,
365 +             },
366 +             ViewParams {
367 +                 pose: head_pose * view_params[1].pose,
368 +                 fov: view_params[1].fov,
369 +             },
370 +         ]
    |

Check warning on line 318 in alvr\client_core\src\lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> alvr\client_core\src\lib.rs:318:19
    |
318 |         callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>,
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check warning on line 66 in alvr\client_core\src\connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> alvr\client_core\src\connection.rs:66:27
   |
66 |     pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>,
   |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 167 in alvr\client_core\src\graphics\mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `adapter` and `dummy_surface` are never read

warning: fields `adapter` and `dummy_surface` are never read
   --> alvr\client_core\src\graphics\mod.rs:167:5
    |
165 | pub struct GraphicsContext {
    |            --------------- fields in this struct
166 |     _instance: Instance,
167 |     adapter: Adapter,
    |     ^^^^^^^
...
174 |     dummy_surface: egl::Surface,
    |     ^^^^^^^^^^^^^

Check warning on line 818 in alvr\client_core\src\c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variants `Float`, `Int32`, `Int64`, and `String` are never constructed

warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed
   --> alvr\client_core\src\c_api.rs:818:5
    |
817 | pub enum AlvrMediacodecPropType {
    |          ---------------------- variants in this enum
818 |     Float,
    |     ^^^^^
819 |     Int32,
    |     ^^^^^
820 |     Int64,
    |     ^^^^^
821 |     String,
    |     ^^^^^^

Check warning on line 71 in alvr\client_core\src\c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `codec` is never read

warning: field `codec` is never read
  --> alvr\client_core\src\c_api.rs:71:9
   |
70 |     DecoderConfig {
   |     ------------- field in this variant
71 |         codec: AlvrCodec,
   |         ^^^^^

Check warning on line 64 in alvr\client_core\src\c_api.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read

warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read
  --> alvr\client_core\src\c_api.rs:64:9
   |
63 |     Haptics {
   |     ------- fields in this variant
64 |         device_id: u64,
   |         ^^^^^^^^^
65 |         duration_s: f32,
   |         ^^^^^^^^^^
66 |         frequency: f32,
   |         ^^^^^^^^^
67 |         amplitude: f32,
   |         ^^^^^^^^^