Skip to content

zarik staging

zarik staging #4259

GitHub Actions / clippy succeeded Sep 12, 2024 in 1s

clippy

70 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 70
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 71964 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`

warning: unused import: `self::VkLoaderFeastureFlagBits as VkLoaderFlagBits`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:71964:9
      |
71964 | pub use self::VkLoaderFeastureFlagBits as VkLoaderFlagBits;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 64273 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`

warning: unused import: `self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:64273:9
      |
64273 | pub use self::VkPrivateDataSlotCreateFlagBits as VkPrivateDataSlotCreateFlagBitsEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 59508 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`

warning: unused import: `self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:59508:9
      |
59508 | pub use self::VkToolPurposeFlagBits as VkToolPurposeFlagBitsEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 56634 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`

warning: unused import: `self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:56634:9
      |
56634 | pub use self::VkPipelineCreationFeedbackFlagBits as VkPipelineCreationFeedbackFlagBitsEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 55649 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`

warning: unused import: `self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:55649:9
      |
55649 | pub use self::VkQueueGlobalPriorityKHR as VkQueueGlobalPriorityEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53622 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`

warning: unused import: `self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53622:9
      |
53622 | pub use self::VkBuildAccelerationStructureFlagBitsKHR as VkBuildAccelerationStructureFlagBitsNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53605 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`

warning: unused import: `self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53605:9
      |
53605 | pub use self::VkGeometryInstanceFlagBitsKHR as VkGeometryInstanceFlagBitsNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53584 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`

warning: unused import: `self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53584:9
      |
53584 | pub use self::VkGeometryFlagBitsKHR as VkGeometryFlagBitsNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53567 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`

warning: unused import: `self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53567:9
      |
53567 | pub use self::VkCopyAccelerationStructureModeKHR as VkCopyAccelerationStructureModeNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53537 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`

warning: unused import: `self::VkGeometryTypeKHR as VkGeometryTypeNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53537:9
      |
53537 | pub use self::VkGeometryTypeKHR as VkGeometryTypeNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 53529 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`

warning: unused import: `self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:53529:9
      |
53529 | pub use self::VkRayTracingShaderGroupTypeKHR as VkRayTracingShaderGroupTypeNV;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 52892 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`

warning: unused import: `self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:52892:9
      |
52892 | pub use self::VkDescriptorBindingFlagBits as VkDescriptorBindingFlagBitsEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 50733 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`

warning: unused import: `self::VkSamplerReductionMode as VkSamplerReductionModeEXT`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:50733:9
      |
50733 | pub use self::VkSamplerReductionMode as VkSamplerReductionModeEXT;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 44495 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`

warning: unused import: `self::VkSubmitFlagBits as VkSubmitFlagBitsKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:44495:9
      |
44495 | pub use self::VkSubmitFlagBits as VkSubmitFlagBitsKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42667 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`

warning: unused import: `self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42667:9
      |
42667 | pub use self::VkSemaphoreWaitFlagBits as VkSemaphoreWaitFlagBitsKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42666 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`

warning: unused import: `self::VkSemaphoreType as VkSemaphoreTypeKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42666:9
      |
42666 | pub use self::VkSemaphoreType as VkSemaphoreTypeKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42661 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`

warning: unused import: `self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42661:9
      |
42661 | pub use self::VkResolveModeFlagBits as VkResolveModeFlagBitsKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42659 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`

warning: unused import: `self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42659:9
      |
42659 | pub use self::VkShaderFloatControlsIndependence as VkShaderFloatControlsIndependenceKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42656 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkDriverId as VkDriverIdKHR`

warning: unused import: `self::VkDriverId as VkDriverIdKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42656:9
      |
42656 | pub use self::VkDriverId as VkDriverIdKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42212 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`

warning: unused import: `self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42212:9
      |
42212 | pub use self::VkSamplerYcbcrRange as VkSamplerYcbcrRangeKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42211 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`

warning: unused import: `self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42211:9
      |
42211 | pub use self::VkSamplerYcbcrModelConversion as VkSamplerYcbcrModelConversionKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 42210 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkChromaLocation as VkChromaLocationKHR`

warning: unused import: `self::VkChromaLocation as VkChromaLocationKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:42210:9
      |
42210 | pub use self::VkChromaLocation as VkChromaLocationKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 41553 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`

warning: unused import: `self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:41553:9
      |
41553 | pub use self::VkTessellationDomainOrigin as VkTessellationDomainOriginKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 41552 in /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`

warning: unused import: `self::VkPointClippingBehavior as VkPointClippingBehaviorKHR`
     --> /home/runner/work/ALVR/ALVR/target/debug/build/alvr_vulkan_layer-e3bb839afe81b656/out/layer_bindings.rs:41552:9
      |
41552 | pub use self::VkPointClippingBehavior as VkPointClippingBehaviorKHR;
      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 416 in alvr/dashboard/src/dashboard/components/statistics.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> alvr/dashboard/src/dashboard/components/statistics.rs:408:25
    |
408 |               ui[1].label(&format!(
    |  _________________________^
409 | |                 "{}% ({})",
410 | |                 statistics.battery_hmd,
411 | |                 if statistics.hmd_plugged {
...   |
415 | |                 }
416 | |             ));
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
    |
408 ~             ui[1].label(format!(
409 +                 "{}% ({})",
410 +                 statistics.battery_hmd,
411 +                 if statistics.hmd_plugged {
412 +                     "plugged"
413 +                 } else {
414 +                     "unplugged"
415 +                 }
416 ~             ));
    |