-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: integrate adb port forwarding #2451
base: master
Are you sure you want to change the base?
Conversation
Why didn't you use mozdevice as you said initially? |
I initially did but then I was told about the launcher using adb, which uses it through commands, so I thought we could avoid a dependency going the same route. |
We should use the dependency if it reduces the amount of boilerplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is strum really needed? Also if you have to do this much amount of wrapping wouldn't it be better to use mozdevice?
No, strum is not strictly needed, I'll use a match then. As for mozdevice, the parsing is very barebones: https://docs.rs/mozdevice/latest/src/mozdevice/lib.rs.html#93 |
There is also |
To be honest this one seems exactly what we need, and no need to download adb. It only implements the sockets part of the protocol, so it cannot be used for the launcher also. |
That library needs an adb server to work, so the download is still needed: https://docs.rs/adb_client/latest/src/adb_client/server/adb_server.rs.html#52 |
Ah hm. In any case seems a good option |
This is shaping very nicely. let me know when it's ready for the final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved too soon. There are a few issues.
- When wired mode is enabled, the trusted client keeps going to "Connecting" then "Disconnected" if there are no connected clients
- The ADB download should show the download percentage. and show the total download size as MBs.
Looking at Infuse VR (commercial ALVR fork) I think it would make more sense to have a separate section to handle wired connections. we don't need to trust wired connections because both pc and headsets must be in the same place and managed by the same person.
This PR adds a toggle for wired connections in the "Edit connection" dialog. When enabled, ALVR manages the forwarding of the required ports using
adb
. If a system installation ofadb
is present, it will be used, falling back to downloading and installing a local copy otherwise.Closes #567, closes #2349.