fix(client_openxr): 🐛 Fix crash on Focus 3 with 0 timestamp #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
force-pushed
the
zero-timestamp-fix
branch
from
a4cd215
to
19bc077
Compare
zmerp
force-pushed
the
zero-timestamp-fix
branch
from
19bc077
to
4cc52b2
Compare
The-personified-devil
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement two fixes which independently fix a crash when the stream timestamp is 0. The
xr_frame_stream.end()retry fallback apparently does not work on the Focus 3, or somehow some internal variables are already changed and we don't need another successful call.