Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server_openvr) NVENC AV1 support #2438

Merged
merged 8 commits into from
Oct 5, 2024
Merged

feat(server_openvr) NVENC AV1 support #2438

merged 8 commits into from
Oct 5, 2024

Conversation

shinyquagsire23
Copy link
Contributor

@shinyquagsire23 shinyquagsire23 commented Oct 4, 2024 •
edited
Loading

Works on my machine 👍

  • Initializes AV1 the same as HEVC/H264 for the most part, except for some terminology differences on SPS/VPS
  • NVENC doesn't have a NAL mode, but AMF doesn't use NALs either. However, NVENC wraps AV1 in the IVF format (packetized), so we have to strip it down to just the OBUs (AV1 equivalent of NALUs). Luckily this is just a matter of trimming of 12 bytes and checking for the 0x20 byte IVF header.
  • Tested with 10-bit, HDR, and limited range encoding, no issues
  • Also fixed logging on visionOS because I needed the printf debugging

zmerp
zmerp requested changes Oct 4, 2024
View reviewed changes
alvr/client_core/src/lib.rs Outdated Show resolved Hide resolved
alvr/client_core/src/logging_backend.rs Outdated Show resolved Hide resolved
alvr/server_openvr/cpp/platform/win32/VideoEncoderNVENC.cpp Outdated Show resolved Hide resolved
@shinyquagsire23
Copy link
Contributor Author

k removed all the logging changes then so no need to rebase probably

@shinyquagsire23 shinyquagsire23 changed the title feat(server_openvr, client_core) NVENC AV1 support; fix logging on Apple platforms feat(server_openvr) NVENC AV1 support Oct 4, 2024
@zmerp zmerp merged commit e991a79 into alvr-org:master Oct 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerp zmerp zmerp approved these changes

@The-personified-devil The-personified-devil Awaiting requested review from The-personified-devil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinyquagsire23 @zmerp