refactor(streamer): ♻️ Clarify distinction between bitrate and throughput #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
force-pushed
the
throughput-rename
branch
5 times, most recently
from
a287e42
to
3bef214
Compare
zmerp
force-pushed
the
throughput-rename
branch
from
3bef214
to
0996842
Compare
The-personified-devil
previously approved these changes
Sep 26, 2024
The-personified-devil
dismissed
their stale review
better sanitization needed
The-personified-devil
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, by the graphs it's clear to see how the requested bitrate and recorded bitrate are roughly the percentage of recorded throughput, given the saturation parameter in Adaptive bitrate. Still, ideally the throughput should be a constant value (on average) independent on the actual selected saturation value. This is not the case and it will get higher or lower depending on the saturation parameter. This is an improvement that can be addressed in the future.