Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): ✨ Expose server version from client_core #2387

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Sep 12, 2024

The new C API is alvr_get_server_version which works similarly to alvr_get_settings_json. The value can be obtained only after server connection, and the string length can be obtained by passing a null buffer.

@shinyquagsire23
Copy link
Contributor

Tested it on visionOS and it seems to work fine, defaults to "20.11.0" on older versions but it seems like client_core works fine for those versions anyhow

@zmerp
Copy link
Member Author

zmerp commented Sep 12, 2024

@shinyquagsire23 What do you mean "defaults to "20.11.0" on older versions"? What did you try?

@shinyquagsire23
Copy link
Contributor

@zarik5 I tested streamer 20.9 and 20.10 from Releases with the patched client_core and it always returned the string "20.11.0"

@zmerp
Copy link
Member Author

zmerp commented Sep 13, 2024

Now I remember why. This is actually caused by sloppy session extrapolation. Thankfully i can implement a fix and this will work retroactively for previous server builds.

@zmerp zmerp merged commit 49d68b5 into master Sep 13, 2024
7 of 9 checks passed
@zmerp zmerp deleted the expose-server-version branch September 13, 2024 22:04
@The-personified-devil
Copy link
Collaborator

Thankfully i can implement a fix and this will work retroactively for previous server builds.

Do you mean knowing that the version is <= 20.11 is good enough and the fix in the server will be implemented later?

@zmerp
Copy link
Member Author

zmerp commented Sep 14, 2024

No, i mean that the server version is already passed correctly but the client mistakenly overwrites and loses the value, because of faulty session extrapolation

@The-personified-devil
Copy link
Collaborator

that's what I was wondering, odd choice to not directly add the fix to the pr then

@zmerp
Copy link
Member Author

zmerp commented Sep 14, 2024

I was thinking about that. You may be right. Anyway I'll make another PR tomorrow

@shinyquagsire23
Copy link
Contributor

honestly for visionOS it kinda works out anyhow, because the issue I thought I needed the versions to patch over (controllers being rotated) was fixed with the client_core update anyhow. Though I might disable the hand skeleton hysteresis on older versions where SteamVR input 2.0 gets set true by default w/o the streamer having those settings present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants