feat(client): ✨ Add Pico 4 Ultra support (#2466)

alvr-org · Oct 20, 2024 · 65a4dd5 · 65a4dd5
1 parent d42701b
commit 65a4dd5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -15,7 +15,7 @@ This is a fork of [ALVR](https://github.com/polygraphene/ALVR).
 |      VR Headset       |                                           Support                                            |
 | :-------------------: | :------------------------------------------------------------------------------------------: |
 |  Quest 1/2/3/3S/Pro   |     :heavy_check_mark: ([store link](https://www.meta.com/experiences/7674846229245715))     |
-|     Pico 4/Neo 3      |                                      :heavy_check_mark:                                      |
+| Pico Neo 3/4/4 Ultra  |                                      :heavy_check_mark:                                      |
 | Vive Focus 3/XR Elite |                                      :heavy_check_mark:                                      |
 |        YVR 1/2        |                                      :heavy_check_mark:                                      |
 |        Lynx R1        |                                      :heavy_check_mark:                                      |

diff --git a/alvr/client_core/src/platform/mod.rs b/alvr/client_core/src/platform/mod.rs
@@ -17,6 +17,9 @@ pub enum Platform {
     QuestUnknown,
     PicoNeo3,
     Pico4,
+    Pico4Ultra,
+    PicoG3,
+    PicoUnknown,
     Focus3,
     XRElite,
     ViveUnknown,
@@ -66,6 +69,9 @@ impl Display for Platform {
             Platform::QuestUnknown => "Quest (unknown)",
             Platform::PicoNeo3 => "Pico Neo 3",
             Platform::Pico4 => "Pico 4",
+            Platform::Pico4Ultra => "Pico 4 Ultra",
+            Platform::PicoG3 => "Pico G3",
+            Platform::PicoUnknown => "Pico (unknown)",
             Platform::Focus3 => "VIVE Focus 3",
             Platform::XRElite => "VIVE XR Elite",
             Platform::ViveUnknown => "HTC VIVE (unknown)",
@@ -97,7 +103,10 @@ pub fn platform() -> Platform {
             ("Oculus", _, "seacliff") => Platform::QuestPro,
             ("Oculus", _, _) => Platform::QuestUnknown,
             ("Pico", "Pico Neo 3" | "Pico Neo3 Link", _) => Platform::PicoNeo3,
-            ("Pico", _, _) => Platform::Pico4,
+            ("Pico", _, "phoenix") => Platform::Pico4,
+            ("Pico", _, "sparrow") => Platform::Pico4Ultra,
+            ("Pico", _, "merline") => Platform::PicoG3,
+            ("Pico", _, _) => Platform::PicoUnknown,
             ("HTC", "VIVE Focus 3", _) => Platform::Focus3,
             ("HTC", "VIVE XR Series", _) => Platform::XRElite,
             ("HTC", _, _) => Platform::ViveUnknown,

diff --git a/alvr/client_openxr/src/lib.rs b/alvr/client_openxr/src/lib.rs
@@ -243,7 +243,10 @@ pub fn entry_point() {
             foveated_encoding: platform != Platform::Unknown,
             encoder_high_profile: platform != Platform::Unknown,
             encoder_10_bits: platform != Platform::Unknown,
-            encoder_av1: matches!(platform, Platform::Quest3 | Platform::Quest3S),
+            encoder_av1: matches!(
+                platform,
+                Platform::Quest3 | Platform::Quest3S | Platform::Pico4Ultra
+            ),
             prefer_10bit: false,
             prefer_full_range: true,
             preferred_encoding_gamma: 1.0,