Skip to content

Commit

Permalink
All up test should fail on container build
Browse files Browse the repository at this point in the history
The all up does previously did not fail if the container build failed,
this would result in strange and difficult to debug behavior as the
tests ran against an older version of the container which may or may not
include your latest changes.
  • Loading branch information
jkilpatr committed Feb 11, 2021
1 parent e054298 commit 6697b96
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/all-up-test.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
#!/bin/bash
set -eux
# the directory of this script, useful for allowing this script
# to be run with any PWD
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

result=$( docker images -q peggy-base )

# builds the container containing various system deps
# also builds Peggy once in order to cache Go deps, this container
# must be rebuilt every time you run this test if you want a faster
Expand All @@ -17,7 +16,9 @@ docker rm -f peggy_all_up_test_instance
set -e

NODES=3
set +u
TEST_TYPE=$1
set -u

# Run new test container instance
docker run --name peggy_all_up_test_instance --cap-add=NET_ADMIN -t peggy-base /bin/bash /peggy/tests/container-scripts/all-up-test-internal.sh $NODES $TEST_TYPE

0 comments on commit 6697b96

Please sign in to comment.