Qualcomm: fix codec initialisation #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lazy include of the four codec initialisation files are incorrectly specified using the same identifier which means that only the last one is actually included. This specifically means that the Speakers and Headphone stereo mixer elements are never defined and cannot be used for hardware volume control. The default Speaker digital volume is also never set by the BootSequence as intended. Signed-off-by: Johan Hovold <[email protected]>
The lazy include of the two codec initialisation files are incorrectly specified using the same identifier which means that only the last one is actually included. This specifically means that the Speakers stereo mixer element is never defined and cannot be used for hardware volume control. Signed-off-by: Johan Hovold <[email protected]>
The lazy include of the four codec initialisation files are incorrectly specified using the same identifier which means that only the last one is actually included. This specifically means that the Speakers and Headphone stereo mixer elements are never defined and cannot be used for hardware volume control. The default Speaker digital volume is also never set by the BootSequence as intended. Signed-off-by: Johan Hovold <[email protected]>
perexg
pushed a commit
that referenced
this pull request
Oct 18, 2024
The lazy include of the two codec initialisation files are incorrectly specified using the same identifier which means that only the last one is actually included. This specifically means that the Speakers stereo mixer element is never defined and cannot be used for hardware volume control. Closes: #454 Signed-off-by: Johan Hovold <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
perexg
pushed a commit
that referenced
this pull request
Oct 18, 2024
The lazy include of the four codec initialisation files are incorrectly specified using the same identifier which means that only the last one is actually included. This specifically means that the Speakers and Headphone stereo mixer elements are never defined and cannot be used for hardware volume control. The default Speaker digital volume is also never set by the BootSequence as intended. Closes: #454 Signed-off-by: Johan Hovold <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Qualcomm configurations that are using the same identifier for lazy includes of codec initialisation files which means that only the last one is actually included.