Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared tests and all utilities to support both unit and integrations tests #6

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

alpsla
Copy link
Owner

@alpsla alpsla commented Dec 11, 2024

Maintained compatibility with all existing tests
Provided proper type safety for the mocks
Kept the flexibility needed for different test scenarios

Proper typing for GitHub API responses using RestEndpointMethodTypes
Correct handling of pull request repository properties
Explicit boolean property settings to avoid undefined values
Type-safe transformations between API responses and internal types

Maintained compatibility with all existing tests
Provided proper type safety for the mocks
Kept the flexibility needed for different test scenarios
…t flag

Added missing TypeScript files to the types and config packages
Installed the missing lucide-react dependency
Fixed the handleSubmit function by:
Moving it into useCallback
Including all necessary dependencies
Moving the repository access check logic inside
Properly typing the event parameter
@alpsla alpsla merged commit b8da65a into main Dec 11, 2024
1 of 2 checks passed
@alpsla alpsla deleted the test_env branch December 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant