Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: (--check-pandoc-no-wrap-option) Handle option has been removed #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: (--check-pandoc-no-wrap-option) Handle option has been removed #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d9c13
Fix: (--check-pandoc-no-wrap-option) Handle option has been removed
aavanian Jan 25, 2024
635f8d7
Change: (--check-pandoc-no-wrap-option) Use regexp
aavanian Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion org-web-tools.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ When SELECTOR is non-nil, the HTML is filtered using
(sleep-for org-web-tools-pandoc-sleep-time)
(cl-incf checked)))
(if (and (zerop (process-exit-status process))
(not (string-match "--no-wrap is deprecated" (buffer-string))))
(not (string-match "--no-wrap is deprecated" (buffer-string)))
(not (string-match "--no-wrap has been removed" (buffer-string))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better written using a single regular expression matching both strings. The rx macro makes these easy to read and write.

As well, this would be a good opportunity to use string-match-p instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done though not sure about your preference about line length and where to break it.

"--no-wrap"
"--wrap=none"))))

Expand Down