-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update obsolete utility calls #58
Update obsolete utility calls #58
Conversation
This will also lint and test PRs' branches. See #58.
Hi Brian, Thanks for noticing these and submitting the PR. It can be challenging to keep up with the symbol renaming that tends to happen upstream. Generally it's necessary to do conditional aliases, like this (or similar for variables), which isn't fun. Rather than digging through Org's history to find out when those variables were renamed, I pushed my makem.sh scripts and CI configuration, and enabled it for PRs, configuring it to run on the most recent major releases. The linter in the GitHub Actions CI should identify where the problem begins, in terms of Emacs versions... |
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
I pushed a nearly no-op commit to the branch to make CI run on it... https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558260847 |
Lines like this are what we're looking for: https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558261020#step:6:99 (Thanks to package-lint) |
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
a28de9b
to
3aa27be
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
3aa27be
to
b7414a8
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
b7414a8
to
6e35ec5
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
6e35ec5
to
9763a39
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
9763a39
to
fa54449
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
fa54449
to
576c621
Compare
Really this is just to make GitHub CI run on this PR. See alphapapa#58.
576c621
to
ac8d185
Compare
@fade Thanks again for submitting this. In the process of tidying up |
Very kind. Thanks. I'm glad they were out some use. |
few trivial updates to squash load-time warnings due to obsolete identifiers. I've tested on emacs 29.1 and on a build of emacs HEAD as of Monday September 4, 2023. Org mode version 9.7-pre (release_9.6.8-747-gf6fc38).
now, I am not well versed in the mechanics of maintaining a package that needs to be backwards compatible to some arbitrary point in the past, so this may not be welcome. If this is the case, I'd appreciate a comment on the procedure for this kind of maintenance. :)
Best regards