Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete utility calls #58

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

fade
Copy link

@fade fade commented Sep 4, 2023

few trivial updates to squash load-time warnings due to obsolete identifiers. I've tested on emacs 29.1 and on a build of emacs HEAD as of Monday September 4, 2023. Org mode version 9.7-pre (release_9.6.8-747-gf6fc38).

now, I am not well versed in the mechanics of maintaining a package that needs to be backwards compatible to some arbitrary point in the past, so this may not be welcome. If this is the case, I'd appreciate a comment on the procedure for this kind of maintenance. :)

Best regards

alphapapa added a commit that referenced this pull request Sep 6, 2023
This will also lint and test PRs' branches.

See #58.
@alphapapa
Copy link
Owner

Hi Brian,

Thanks for noticing these and submitting the PR. It can be challenging to keep up with the symbol renaming that tends to happen upstream. Generally it's necessary to do conditional aliases, like this (or similar for variables), which isn't fun.

Rather than digging through Org's history to find out when those variables were renamed, I pushed my makem.sh scripts and CI configuration, and enabled it for PRs, configuring it to run on the most recent major releases. The linter in the GitHub Actions CI should identify where the problem begins, in terms of Emacs versions...

alphapapa added a commit to fade/org-web-tools that referenced this pull request Sep 6, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa
Copy link
Owner

alphapapa commented Sep 6, 2023

I pushed a nearly no-op commit to the branch to make CI run on it...

https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558260847

@alphapapa
Copy link
Owner

Lines like this are what we're looking for: https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558261020#step:6:99 (Thanks to package-lint)

alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from a28de9b to 3aa27be Compare October 29, 2023 03:19
alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from 3aa27be to b7414a8 Compare October 29, 2023 03:30
alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from b7414a8 to 6e35ec5 Compare October 29, 2023 03:33
alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from 6e35ec5 to 9763a39 Compare October 29, 2023 03:48
alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from 9763a39 to fa54449 Compare October 29, 2023 03:51
alphapapa added a commit to fade/org-web-tools that referenced this pull request Oct 29, 2023
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from fa54449 to 576c621 Compare October 29, 2023 03:53
Brian O'Reilly and others added 2 commits October 28, 2023 22:58
Really this is just to make GitHub CI run on this PR.  See alphapapa#58.
@alphapapa alphapapa force-pushed the update-obsolete-utility-calls branch from 576c621 to ac8d185 Compare October 29, 2023 03:58
@alphapapa alphapapa merged commit 2dbf1af into alphapapa:master Oct 29, 2023
0 of 5 checks passed
@alphapapa
Copy link
Owner

alphapapa commented Oct 29, 2023

@fade Thanks again for submitting this. In the process of tidying up master I inadvertently made some changes that were already made in this branch by you, so I marked you as a co-author of those commits, then rebased and merged this branch.

@fade
Copy link
Author

fade commented Oct 29, 2023

Very kind. Thanks. I'm glad they were out some use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants