(828) Reorder content block editing screens #9869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we couldn’t nest the two buttons within the form, as the delete button has a form of its own. We previously hacked around this, but this resulted in invalid HTML, but now the button component has a `form` option, which allows us to point the button to a form with a specific ID.
pezholio
force-pushed
the
content-modelling/828-reorder-note-screens
branch
2 times, most recently
from
408c7c6 to
e298a30
Compare
I’ve tweaked the expecations in the Cucumber features too, as it doesn’t make sense to send users to the homepage when cancelling
According to the designs, the schedule/publish step should come after the changenotes
pezholio
force-pushed
the
content-modelling/828-reorder-note-screens
branch
from
e298a30 to
33c143f
Compare
Harriethw
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/eqAcYy1U/828-add-internal-and-external-change-notes-when-editing-blocks
This reorders the content block editing screens, as well as making sure all the cancel buttons behave in the same way, fixing an issue where we had to add invalid HTML to get the Continue/Cancel buttons to line up.