Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline styling of bold text on a results page #6909

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Oct 15, 2024

What

Fixed a styling issue with bold text on the check benefits financial support results page.

Why

Noticed a console error when completing a review of app components, it seems inline styles are no longer applied.

Visual Changes

Before After
bold-before bold-after

Page example: https://www.gov.uk/check-benefits-financial-support/y/england/no/no/yes/yes/yes_unable_to_work/no/no/dont_know/none_16000

Inline styles are no longer applied, replaced with the `govuk-!-font-weight-bold` font override class from the design system.
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6909 October 15, 2024 09:17 Inactive
@MartinJJones MartinJJones changed the title Fix inline styling Fix inline styling of bold text on a results page Oct 15, 2024
Copy link
Contributor

@davidtrussler davidtrussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MartinJJones MartinJJones merged commit feee101 into main Oct 16, 2024
13 checks passed
@MartinJJones MartinJJones deleted the fix-inline-style branch October 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants