Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 scroll tracking #6483

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add GA4 scroll tracking #6483

merged 1 commit into from
Jul 28, 2023

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Adds GA4 scroll tracking to various smart answer result pages.

Why

Part of the GA4 migration.

Visual changes

None.

Trello card: https://trello.com/c/nmdZiLNu/615-scroll-tracking-heading-type-smart-answers

@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6483 July 28, 2023 10:02 Inactive
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andysellick Looks good - just one bit of code was left in by accident I think!

app/views/smart_answers/custom_result_full_width.erb Outdated Show resolved Hide resolved
- adds GA4 scroll tracking to various smart answer result pages
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andysellick andysellick merged commit 43cec85 into main Jul 28, 2023
6 checks passed
@andysellick andysellick deleted the add-ga4-scroll-tracking branch July 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants