Tidy up organisation lists #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
tidy-up-organisation-lists
branch
from
cecbf45
to
f2d59f5
Compare
This brings the spec more in line with others. It also removes some spec-level setup, since it was only used in a couple of tests - setting it up before every tests feels inefficient
... one for active organisations, one for inactive. This will reduce the closed organisation noise and make it easier to look through active organisations by default. We'll separately set a default order on organisations so that closed ones come last, but this felt like a nicer way to handle the organisations index, and follows the pattern established by the applications index This required a change to a 2SV integration test so that it looks for a table within the active tab/container, since both tabs and hence both tables are within the underlying HTML. Initially I looked to extend existing methods in the `HtmlTableHelpers` file to allow us to look for a table within the right container, but I noticed that the helper's methods were only used in this integration test. Since their use case was specific to this spec, I've opted to reduce the abstraction here and keep it simple, similar to recent minor shifts in the approach to access and permissions integration tests. This reduces complexity in the codebase, and brings all the relevant code closer to the context of the tests - I'm not always a proponent of this approach, but it felt appropriate here given the limited use case!
yndajas
force-pushed
the
tidy-up-organisation-lists
branch
from
f2d59f5
to
c0da0f4
Compare
Given all the organisation autocompletes filter out closed organisations and the organisations index is now tabbed, the closed ordering might only affect the users index filter at present. We could alternatively just sort manually in this use case Ordering by a Boolean field seemed a little tricky, but this helepd: https://stackoverflow.com/a/12334676/4002016
yndajas
force-pushed
the
tidy-up-organisation-lists
branch
from
c0da0f4
to
c5a7c56
Compare
JonathanHallam
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Screenshots
Before
After
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.