Rename 'delegatable' permissions to 'delegated' #3205
Conversation
| title: "What is a 'delegated' permission?" | ||
| } do %> | ||
| <p class="govuk-body"> | ||
| When a permission is delegated, publishing managers are able to grant the |
There was a problem hiding this comment.
This is a helpful explainer, but I'm not sure I understand the distinction between "delegated" and "delegatable" here. Isn't "delegatable" the right word here for someone being able to delegate a thing? Using the past participle feels like a thing that's already happened, rather than a thing that can happen
There was a problem hiding this comment.
I can see how this could be confusing, and I think the choice of distinguishing verbs isn't the most natural, but 'delegating' and 'granting' permissions are two separate concepts. We grant permissions to individuals, while we delegate the authority to grant permissions to publishing managers. I wonder if we need to clarify that here (and maybe also in the access and permissions documentation)?
There was a problem hiding this comment.
tl;dr 'delegated' == 'grantable by publishing managers'
|
Makes sense to me as well. It take me reading your other comment explaining this to George for me to figure out exactly what's going on, so it's not super natural, but I do understand and agree with the terminology. |
This renames the `SupportedPermission` field `delegatable` to `delegated`, in line with our revised and hopefully clearer terminology: - all permissions are 'delegatable' - all permissions are delegatable because we have a feature that supports 'delegating' permissions (on the `SupportedPermission` model) - some permissions are 'delegated', meaning organisation/super organisation admins can grant them to users they can manage
yndajas
force-pushed
the
improve-delegatable-language
branch
from
ac06c21
to
8dcc438
Compare
Trello
This came out of work to fix 'delegatable' permissions. We've gradually settled on some new terminology, the main change being that we now refer to them as 'delegated' permissions (all permissions are delegatable). This updates the codebase, including the UI and documentation, to reflect that shift
Screenshots
Before
After
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.