Lightly clean up Sentry event logging. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
force-pushed
the
sengi/sentry-cleanup
branch
from
88429f1
to
2d2f8c6
Compare
sengi
force-pushed
the
sengi/sentry-cleanup
branch
from
2d2f8c6
to
b191bc1
Compare
theseanything
approved these changes
Aug 28, 2024
We're still quite some way from using the Sentry API as intended, but this at least makes our usage a bit less weird/buggy and more readable. - Send events to Sentry asynchronously, instead of blocking. - Allow up to 2 s to finish sending events to Sentry on exit. - Manage the lifecycle of the sentry.Client, Hub and Scope objects the way we're supposed to, rather than reinitialising Sentry every time we send an event. - Remove the unexported methods on our (still somewhat sketchy) ReportableError type; these weren't helping readability. Relevant docs: - https://docs.sentry.io/platforms/go/usage/ - https://docs.sentry.io/platforms/go/enriching-events/scopes/ - https://docs.sentry.io/platforms/go/concurrency/ - https://docs.sentry.io/platforms/go/panics/ - https://docs.sentry.io/platforms/go/guides/http/ - https://github.com/getsentry/sentry-go/blob/master/_examples/http/main.go
theseanything
force-pushed
the
sengi/sentry-cleanup
branch
from
d69710d
to
51efa77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still quite some way from using the Sentry API as intended, but this at least makes our usage a bit less weird/buggy and more readable.
Relevant docs: