Refactor table-driven test that was doing too much. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
force-pushed
the
sengi/refactor-heinous-table-test
branch
from
d67ba5b
to
fdf6b9e
Compare
This giant table-driven test was full of branches and was testing a whole bunch of different behaviours. - Split it into separate tests that test one thing each. - Stop doing exact comparisons on floating point numbers. - Clean up the other few tests in the module. - Use table-driven tests where appropriate.
sengi
force-pushed
the
sengi/refactor-heinous-table-test
branch
from
fdf6b9e
to
a9f47e7
Compare
|
cc @chao-xian |
theseanything
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table-driven test was full of branches and was testing a whole bunch of different behaviours.