Update all dependencies to current versions. #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were stuck on v12.7.0 because we weren't specifying `/v12` in the import. Recent-ish versions of Go require explicitly specifying the major version in the import statement like this when the major version is greater than 1. This is so that `go get -u` doesn't automatically break things by updating major versions of libraries.
|
cc @chao-xian |
|
This supersedes #371. |
sengi
force-pushed
the
sengi/mod-update
branch
3 times, most recently
from
6c6395e
to
ce57b4d
Compare
Plus a couple of trivial fixes for house style.
theseanything
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were stuck on a somewhat old version of tsenart/vegeta for a while because we hadn't added the
/v12to the import (see commit).Recommend reviewing commit-by-commit. Only the first and last commits are hand-edits; the rest are just generated by
go get -t -u ./... && go mod tidy && go mod vendor.This supersedes #371.
Tested: Router tests pass locally as well as on GitHub; also ran
go test alllocally and there were no interesting failures (just a broken test in crypto/x509 because a dummy cert in a test fixture has expired)