Skip to content

Commit

Permalink
Change shouldPreserveSegements to work with CsRoute
Browse files Browse the repository at this point in the history
This allows the function be used with either CsRoute or the existing
Route type.
  • Loading branch information
theseanything committed Nov 4, 2024
1 parent 519a8bb commit 2bf35aa
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ func loadRoutes(c *mgo.Collection, mux *triemux.Mux, backends map[string]http.Ha
logDebug(fmt.Sprintf("router: registered %s (prefix: %v) for %s",
incomingURL.Path, prefix, route.BackendID))
case "redirect":
handler := handlers.NewRedirectHandler(incomingURL.Path, route.RedirectTo, shouldPreserveSegments(route))
handler := handlers.NewRedirectHandler(incomingURL.Path, route.RedirectTo, shouldPreserveSegments(route.RouteType, route.SegmentsMode))
mux.Handle(incomingURL.Path, prefix, handler)
logDebug(fmt.Sprintf("router: registered %s (prefix: %v) -> %s",
incomingURL.Path, prefix, route.RedirectTo))
Expand All @@ -347,12 +347,12 @@ func loadRoutes(c *mgo.Collection, mux *triemux.Mux, backends map[string]http.Ha
}
}

func shouldPreserveSegments(route *Route) bool {
switch route.RouteType {
func shouldPreserveSegments(routeType, segmentsMode string) bool {
switch routeType {
case RouteTypeExact:
return route.SegmentsMode == SegmentsModePreserve
return segmentsMode == SegmentsModePreserve
case RouteTypePrefix:
return route.SegmentsMode != SegmentsModeIgnore
return segmentsMode != SegmentsModeIgnore
default:
return false
}
Expand Down

0 comments on commit 2bf35aa

Please sign in to comment.