Open diagram for smart answer in new tab

alphagov · Dec 18, 2023 · 9154f95 · 9154f95
1 parent 660293b
commit 9154f95
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/app/views/editions/diagram.html.erb b/app/views/editions/diagram.html.erb
@@ -1,9 +1,5 @@
 <%= render 'shared/edition_header' %>
 
-<p>
-  <%= link_to "Back to current edition", edition_path(@resource.history.first), :class => "btn btn-default" %>
-</p>
-
 <div class="smart-answer-flowchart" data-module="smart-answer-flowchart">
   <pre class="mermaid flowchart flowchart--hidden">
     <%= @resource.generate_mermaid %>

diff --git a/app/views/editions/show.html.erb b/app/views/editions/show.html.erb
@@ -29,7 +29,7 @@
           <div class="link-check-report col-md-4">
             <% if @edition.class.to_s == "SimpleSmartAnswerEdition" %>
               <p>
-                View the <%= link_to "flow diagram", diagram_edition_path(@edition) %>
+                View the <%= link_to "flow diagram (opens in a new tab)", diagram_edition_path(@edition), target: '_blank' %>
               </p>
             <% end %>
 

diff --git a/test/functional/editions_controller_test.rb b/test/functional/editions_controller_test.rb
@@ -1048,15 +1048,15 @@ class EditionsControllerTest < ActionController::TestCase
 
       get :show, params: { id: simple_smart_answer.id }
 
-      assert_select ".link-check-report p", { text: "View the flow diagram" } do
+      assert_select ".link-check-report p", { text: "View the flow diagram (opens in a new tab)" } do
         assert_select "a[href=?]", diagram_edition_path(simple_smart_answer).to_s,
-                      { count: 1, text: "flow diagram" }
+                      { count: 1, text: "flow diagram (opens in a new tab)" }
       end
     end
 
     should "not render a link to the diagram when edition is not a simple smart answer" do
       get :show, params: { id: @guide.id }
-      assert_select "p", { count: 0, text: "View the flow diagram" }
+      assert_select "p", { count: 0, text: "View the flow diagram (opens in a new tab)" }
     end
   end