Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data attributes for option select button #3750

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Data attributes for option select button #3750

merged 1 commit into from
Dec 11, 2023

Commits on Dec 7, 2023

  1. Attributes for option select button 

    - modify the option select component to allow it to accept data attributes to be added to the expand/collapse button
- the attributes are rendered on the parent element, then read in by JavaScript to be included in the JavaScript generated button, which replaces the title element of the component
- to be used for GA4 tracking purposes in finder-frontend, in place of an existing solution
- will be a breaking change, as removes the event listener that was previously being used for this
- credit to @floehopper
    @andysellick
    andysellick committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    114d9ed View commit details
    Browse the repository at this point in the history