Turn off automatic deployments #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic deployments are designed with integration in mind and don't work when production is the target (as is the case for us). This project requires manual deployment. (And already did require that before this commit, only it didn't know it yet.) I've made the bare minimum change to turn this feature off: removing the `release` trigger from the workflow file. But I have left some of its supporting code in place. Github workflows setups are mostly identical across our code bases and occasionally multiple projects receive fixes and updates to these files simultaneously. I'm optimistically embracing the idea that the closer we can keep this project's versions of these files, the more likely it is that we'll receive fixes and updates when those other projects do.
aldavidson
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/jDSDGNyn/814-measure-and-record-our-publishing-latency-sli
Automatic deployments are designed with integration in mind and don't work when production is the target (as is the case for us).
This project requires manual deployment. (And already did require that before this commit, only it didn't know it yet... see https://github.com/alphagov/govuk-sli-collector/actions/runs/7290021346)