Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Sentry #5

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Install Sentry #5

merged 6 commits into from
Dec 22, 2023

Commits on Dec 7, 2023

  1. Install sentry-ruby gem

    We'll still need to call `Sentry.init` somewhere, but I don't think the
    right place to do that exists yet.
    mike29736 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    42c244b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Introduce Error singleton

    For sending exceptions to Sentry. One method sends and silences the
    exception, the other sends and re-raises it.
    
    `Sentry.init` needed to be called before we used any Sentry methods, so
    while it's a little bit gross, this ended up feeling like the right
    place.
    
    Our Helm chart already includes the SENTRY_DSN, SENTRY_CURRENT_ENV and
    SENTRY_RELEASE in our job's environment, by the way, so Sentry should be
    configured out-of-the-box. (Othewise, we'd supply configuration to
    `Sentry.init`.)
    mike29736 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    084a8e0 View commit details
    Browse the repository at this point in the history
  2. Remove redundant namespace

    Nothing's changed, I just spotted that this isn't needed
    mike29736 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    298ef41 View commit details
    Browse the repository at this point in the history
  3. Put spec example in a describe

    I might merge these commits later, but attempting to minimise noise in
    the commits where I'm actually doing something
    mike29736 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    71ced00 View commit details
    Browse the repository at this point in the history
  4. Capture exceptions from individual SLI class(es)

    Send exceptions to Sentry and don't let them propagate any further.
    
    I imagine this allowing us to add new SLI classes without any one class
    preventing the others collecting their data.
    mike29736 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ea77e5d View commit details
    Browse the repository at this point in the history
  5. Send top-level exceptions to Sentry, too

    But allow them to propagate so that they can result in a non-zero exit
    code and so that they're also sent to Logit
    mike29736 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    781c6e3 View commit details
    Browse the repository at this point in the history