Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causing an error when session-data-defaults is malformed. #2417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nataliecarey
Copy link
Contributor

This resolves the reported issue #2416

The error showing in the browser

The error showing in the terminal

To reproduce this, edit the file app/data/session-data-defaults.js in a way that breaks it. My test file contents was to add one line containing a syntax error to the default file:

module.exports = {
  'broken'
  // Insert values here

}

If that file is then deleted then the default value of {} is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant