Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate infra-public-wafs from govuk-aws #1593

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

theseanything
Copy link
Contributor

@theseanything theseanything commented Jan 22, 2025

This is the initial step to migrating infra-public-wafs from govuk-aws.

aws_wafv2_web_acl_logging_configuration need to be manually imported, as the terraform provider doesn't support the data objects for retrieving the "ids".

@theseanything theseanything force-pushed the migrate-public-wafs branch 12 times, most recently from 9f7cfd9 to 3d76e10 Compare January 27, 2025 14:34
@theseanything theseanything changed the title Add WAFs Migrate infra-public-wafs from govuk-aws Jan 27, 2025
This is the initial import of the wafs.
@theseanything theseanything requested review from samsimpson1 and a team January 27, 2025 14:48
@theseanything theseanything marked this pull request as ready for review January 27, 2025 14:49
@samsimpson1
Copy link
Member

I assume you're planning on using terraform import commands for the logging config, that will probably be fine but if not you could do something similar to what I had to do for the CSP reporter and create a list of the ID for each env

https://github.com/alphagov/govuk-infrastructure/blob/c3e15189a19c6f31474d2228ac0160fd9b2fd7b7/terraform/deployments/csp-reporter/imports.tf

@theseanything theseanything merged commit 033eff6 into main Jan 27, 2025
4 checks passed
@theseanything theseanything deleted the migrate-public-wafs branch January 27, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants