Mount /tmp as a tmpfs volume to work around #537 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a workaround for the issue #537. It allows the Content Publisher and Whitehall test suites to pass in the GOV.UK Docker development environment. Once docker/for-linux#1015 has been fixed, this workaround will no longer be needed.
|
Nice work @ollietreend ⭐ - great to hear there's an alternative option to the rather grim ones I presented in: #537 I don't know too much about tmpfs to know what the trade-offs are here. Is the /tmp mount localised to an individual container? i.e. has an ephemeral lifespan that matches the container; or does it persist? does it get shared between containers at all? |
|
@kevindew as I understand it, the I've just had a quick play with some containers running in parallel and that's the behaviour I observed. |
|
That sounds great - let's give it a go. Could you write a reply to the GitHub issue just to indicate there's a workaround? |
kevindew
approved these changes
Dec 7, 2021
ollietreend
added a commit
that referenced
this pull request
Dec 13, 2021
This change fixes a regression in filesystem permissions introduced in #539, which stopped `ruby-build` from being able to build the Ruby version required by `rbenv`. After #539 was merged, we started seeing the following error message when building the Whitehall and Content Publisher apps: ``` ruby-build: TMPDIR=/tmp cannot hold executables (partition possibly mounted with `noexec`) ``` The error was triggered by running `make whitehall` or `make content-publisher` to re-build the app's docker image. However it also dependended on the docker cache being empty, because otherwise the required Ruby version would already exist in a cached image layer and wouldn't need to be re-installed. The cause for the error was the new `tmpfs` volume which was mounted at `/tmp`. By default, `docker-compose` mounts `tmpfs` volumes with the `noexec` flag, which means that files inside the `/tmp` directory cannot be executed. But `ruby-build` needs to execute files in `/tmp` in order to build Ruby. This change re-enables execution of files inside `/tmp` by including the `exec` flag on the `tmpfs` volume mount.
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 21, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 21, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 21, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 21, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 21, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
May 22, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
tillprochaska
added a commit
to tactilenews/100eyes
that referenced
this pull request
Jul 12, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
mattwr18
pushed a commit
to tactilenews/100eyes
that referenced
this pull request
Jul 27, 2022
For some reason, temporary files weren’t created correctly when running tests inside our Docker development environment. This seems to be a Docker issue that can be worked around by mounting the `/tmp` directory. References: alphagov/govuk-docker#539 docker/for-linux#1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a workaround for the issue #537. It allows the Content Publisher and Whitehall test suites to pass in the GOV.UK Docker development environment.
Once docker/for-linux#1015 has been fixed, this workaround will no longer be needed.