Recruitment banner gem test #3405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
recruitment-banner-gem-test
branch
from
4fad391
to
c97e7ad
Compare
leenagupte
reviewed
Nov 12, 2024
| @@ -31,6 +31,8 @@ | |||
|
|
|||
| <main role="main" id="content" class="<%= @content_item.schema_name.dasherize %>" lang="<%= I18n.locale %>"> | |||
| <span id="Top"></span> | |||
| <%= render partial: "govuk_web_banners/recruitment_banner" if recruitment_banner.present? %> | |||
There was a problem hiding this comment.
Ideally this would be <%= render "govuk_web_banners/recruitment_banner" %>
There was a problem hiding this comment.
Thanks - yeah, I've done that.
- banner partial call is added above the yield to :main in the layout. This is a single-point replacement that matches where the banners are currently being added (right at the top of the body of the affected views)
KludgeKML
force-pushed
the
recruitment-banner-gem-test
branch
from
c97e7ad
to
acda293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the in-built banner code with that from the govuk_web_banners gem.
https://trello.com/c/aYXKcrCo/375-create-govukwebbanner-gem-with-support-for-recruitment-banners