Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HMRC banner dated 29.08.24 #3397

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Remove HMRC banner dated 29.08.24 #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/views/content_items/answer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@

<%= @requested_variant.analytics_meta_tag.html_safe if @requested_variant.present? %>
<% end %>
<%= render 'shared/intervention_banner' %>
<%= render 'content_items/body_with_related_links' %>
2 changes: 0 additions & 2 deletions app/views/content_items/guide.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

<% content_for :simple_header, true %>

<%= render 'shared/intervention_banner' %>

<div class="govuk-grid-row gem-print-columns-none">
<div class="govuk-grid-column-two-thirds">
<%= render 'govuk_publishing_components/components/title', { title: @content_item.content_title } %>
Expand Down
14 changes: 0 additions & 14 deletions lib/data/recruitment_banners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,6 @@
# - /foreign-travel-advice

banners:
- name: HMRC banner 29/08/2024
suggestion_text: "Help improve GOV.UK"
suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"
survey_url: https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance
page_paths:
- /government/collections/tax-compliance-detailed-information
- /government/collections/hm-revenue-and-customs-compliance-checks-factsheets
- /difficulties-paying-hmrc
- /tax-help
- /get-help-hmrc-extra-support
- /guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support
- /tax-appeals
- /guidance/how-to-get-a-review-of-an-hmrc-decision
- /guidance/tax-disputes-alternative-dispute-resolution-adr
- name: HMRC banner 21/10/2024
suggestion_text: "Help improve GOV.UK"
suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"
Expand Down
78 changes: 0 additions & 78 deletions test/integration/recruitment_banner_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,84 +1,6 @@
require "test_helper"

class RecruitmentBannerTest < ActionDispatch::IntegrationTest
def hmrc_banner_survey_url
"https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance"
end

test "HMRC banner 29/08/2024 is displayed on detailed guides of interest" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide_paths = [
"/guidance/voluntary-and-community-sector-organisations-who-can-give-you-extra-support",
"/guidance/how-to-get-a-review-of-an-hmrc-decision",
"/guidance/tax-disputes-alternative-dispute-resolution-adr",
]

detailed_guide_paths.each do |path|
detailed_guide["base_path"] = path
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on document collections of interest" do
document_collection = GovukSchemas::Example.find("document_collection", example_name: "document_collection")
document_collection_paths = [
"/government/collections/tax-compliance-detailed-information",
"/government/collections/hm-revenue-and-customs-compliance-checks-factsheets",
]

document_collection_paths.each do |path|
document_collection["base_path"] = path
stub_content_store_has_item(document_collection["base_path"], document_collection.to_json)
visit document_collection["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on guides of interest" do
guide = GovukSchemas::Example.find("guide", example_name: "guide")
guide_paths = [
"/difficulties-paying-hmrc",
"/tax-help",
"/get-help-hmrc-extra-support",
"/tax-appeals",
]

guide_paths.each do |path|
guide["base_path"] = path
stub_content_store_has_item(guide["base_path"], guide.to_json)
visit guide["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end
end

test "HMRC banner 29/08/2024 is displayed on answer pages of interest" do
answer = GovukSchemas::Example.find("answer", example_name: "answer")

answer["base_path"] = "/tax-help"
stub_content_store_has_item(answer["base_path"], answer.to_json)
visit answer["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Sign up to take part in user research (opens in a new tab)", href: hmrc_banner_survey_url)
end

test "HMRC banner 29/08/2024 is not displayed on all pages" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide["base_path"] = "/nothing-to-see-here"
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert_not page.has_css?(".gem-c-intervention")
end

test "HMRC banner 21/10/2024 is displayed on detailed guide of interest" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")

Expand Down
Loading