Enable form data UTF-8 sanitisation #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2938-enable-form-data-sanitisation
branch
from
559a027
to
0fde4dd
Compare
unoduetre
force-pushed
the
2938-enable-form-data-sanitisation
branch
from
0fde4dd
to
c7934c8
Compare
unoduetre
changed the base branch from
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l
to
2938-different-approach
unoduetre
force-pushed
the
2938-enable-form-data-sanitisation
branch
from
c7934c8
to
0a7e489
Compare
unoduetre
changed the base branch from
2938-different-approach
to
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l-2
unoduetre
force-pushed
the
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l-2
branch
from
05a6fc7
to
99f3f8e
Compare
Base automatically changed from
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l-2
to
main
October 31, 2024 10:52
unoduetre
force-pushed
the
2938-enable-form-data-sanitisation
branch
from
0a7e489
to
4b9aa67
Compare
See: * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L21 * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L84 * https://github.com/whitequark/rack-utf8_sanitizer/blob/b069c9ef6d69e58695ec9a7cad68c41b57812468/lib/rack/utf8_sanitizer.rb#L121
unoduetre
force-pushed
the
2938-enable-form-data-sanitisation
branch
from
4b9aa67
to
4b29246
Compare
hannako
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
After developing the solution presented in this PR, @hannako decided that it would be good to also sanitise and ignore exceptions raised from form data UTF-8 encoding issues. This PR introduces that change.
Why
As a follow up to the PR resolving this Trello ticket