Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Govuk web banner test #4187

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ gem "govuk_ab_testing"
gem "govuk_app_config"
gem "govuk_personalisation"
gem "govuk_publishing_components"
gem "govuk_web_banners", git: "https://github.com/alphagov/govuk_web_banners.git", branch: "add-recruitment-banners"
gem "htmlentities"
gem "plek"
gem "rack-utf8_sanitizer"
Expand Down
10 changes: 10 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
GIT
remote: https://github.com/alphagov/govuk_web_banners.git
revision: ea257b921840ad4b9736cce0e4d3ece9a9b42041
branch: add-recruitment-banners
specs:
govuk_web_banners (0.1.0)
govuk_publishing_components
rails (>= 7)

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -731,6 +740,7 @@ DEPENDENCIES
govuk_publishing_components
govuk_schemas
govuk_test
govuk_web_banners!
htmlentities
i18n-coverage
listen
Expand Down
2 changes: 2 additions & 0 deletions app/assets/javascripts/dependencies.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@
//= require govuk_publishing_components/components/tabs

//= require govuk_publishing_components/components/chart

//= require govuk_web_banners/dependencies
27 changes: 0 additions & 27 deletions app/helpers/recruitment_banner_helper.rb

This file was deleted.

3 changes: 3 additions & 0 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
<% if publication && publication.in_beta %>
<%= render 'govuk_publishing_components/components/phase_banner', phase: "beta" %>
<% end %>

<%= render partial: "govuk_web_banners/recruitment_banner" if recruitment_banner.present? %>

<% unless current_page?(root_path) || !(publication || @calendar) || remove_breadcrumbs(content_item) %>
<%= render 'govuk_publishing_components/components/contextual_breadcrumbs', content_item: content_item_hash %>
<% end %>
Expand Down
10 changes: 0 additions & 10 deletions app/views/shared/_intervention_banner.html.erb

This file was deleted.

11 changes: 0 additions & 11 deletions lib/data/recruitment_banners.yml

This file was deleted.

14 changes: 0 additions & 14 deletions spec/fixtures/recruitment_banners.yml

This file was deleted.

46 changes: 0 additions & 46 deletions spec/helpers/recruitment_banner_helper_spec.rb

This file was deleted.