Stop converting nil graph values to zero

Calling `to_f` or `to_i` on a nil value converts it zero. This is not the desired behaviour as we'd rather show a gap in the graph when the data is missing.
alphagov · Nov 14, 2024 · 305b5c1 · 305b5c1
1 parent 5172917
commit 305b5c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/models/landing_page/block/statistics.rb b/app/models/landing_page/block/statistics.rb
@@ -13,7 +13,7 @@ def x_axis_keys
     def rows
       csv_headers[1..].map do |header|
         values = csv_rows.map do |row|
-          row[header].to_f
+          row[header].to_f if row[header].present?
         end
 
         {

diff --git a/spec/models/landing_page/block/statistics_spec.rb b/spec/models/landing_page/block/statistics_spec.rb
@@ -89,8 +89,8 @@
             0.6,
             0.7,
             0.5,
-            0.0,
-            0.0,
+            nil,
+            nil,
             0.5,
             0.6,
           ],