Autocomplete: Use URL helper instead of absolute_url_for
#3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses Rails's standard URL helper instead of the custom one in the app to establish the absolute URL for the autocomplete endpoint.
csutter
force-pushed
the
autocomp-use-url
branch
from
53c0c85
to
55c7ccd
Compare
kevindew
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Nice one 👍
Based off what we found I'll just leave a comment for prosperity that if we find there's a problem with this (edge case we didn't consider with proxy headers) we could resolve the quoted string problem with: absolute_url_for(api_search_autocomplete_path(format: :json)).to_s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Rails's standard URL helper instead of the custom one in the app to establish the absolute URL for the autocomplete endpoint.