Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.json used by heroku #3558

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Update app.json used by heroku #3558

merged 1 commit into from
Nov 11, 2024

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Nov 11, 2024

Review apps are failing when installing yarn-v1.22.22.
The error message from Heroku suggested specifically adding a buildpack for node.js before the ruby buildpack is fetched.

See logs here

Related PR alphagov/government-frontend#3413

Review apps arre failing when installing yarn-v1.22.22.
The error message from Heroku suggested specifically adding
a buildpack for node.js before the ruby buildpack is fetched.
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3558 November 11, 2024 14:21 Inactive
@hannako hannako removed the request for review from leenagupte November 11, 2024 14:25
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannako hannako merged commit 90319e3 into main Nov 11, 2024
13 checks passed
@hannako hannako deleted the review_apps branch November 11, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants