Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option select styling #3167

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix option select styling #3167

merged 1 commit into from
Sep 22, 2023

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Sep 22, 2023

What

Always ensure the option-select and checkbox stylesheets are requested,
otherwise, the helper methods to add the stylesheets are not called when
aching is used

Why

Fix a layout issue on live

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

  Always ensure the option-select and checkbox stylesheets are requested,
  otherwise the helper methods to add the stylesheets are not called when
  caching is used
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3167 September 22, 2023 10:31 Inactive
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the fix! Thanks Martin!

@maxgds maxgds merged commit 7cd96b1 into main Sep 22, 2023
8 checks passed
@maxgds maxgds deleted the fix-option-select-styling branch September 22, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants