Allow manually calling search-api-v2
#3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
approved these changes
Sep 12, 2023
| @@ -99,5 +103,9 @@ def fetch_search_response(content_item) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def use_v2_api? | |||
| ActiveModel::Type::Boolean.new.cast(filter_params["use_v2"]) | |||
As a first step to building the integration with `search-api-v2`, allow `finder-frontend` to call it if and only if an explicit `use_v2` query parameter is supplied. - Bump `gds-api-adapters` to get new adapter for `search-api-v2` - Add `Services#search_api_v2` - Update `Search::Query` to call `search-api-v2` if `use_v2` parameter is present and truthy (accoring to `ActiveModel::Type::Boolean`)
csutter
force-pushed
the
search-api-v2
branch
from
5a2a2ba
to
91d6b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to building the integration with
search-api-v2, allowfinder-frontendto call it if and only if an explicituse_v2query parameter is supplied.gds-api-adaptersto get new adapter forsearch-api-v2Services#search_api_v2Search::Queryto callsearch-api-v2ifuse_v2parameter is present and truthy (accoring toActiveModel::Type::Boolean)