Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint-config-gds from 0.3.0 to 1.0.0 #3122

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 27, 2023

Bumps stylelint-config-gds from 0.3.0 to 1.0.0.

Changelog

Sourced from stylelint-config-gds's changelog.

1.0.0

This release upgrades to Stylelint 15 and now includes:

  • Checks for media query syntax, rules and values
  • Checks for number precision inside CSS functions
  • Fixes for duplicate rules with intentionally different units

Read about breaking changes in the Stylelint Migrating to v15.0.0 guide.

Breaking change: Removal of stylistic rules

We have removed all stylistic rules (such as tabs/spaces, indentation, etc) as they're no longer included in Stylelint common configurations as part of their deprecation in Stylelint 15.

As per Stylelint's own documentation, we recommend that projects adopt Prettier for formatting instead.

If this is not possible for your project, you can configure your projects' Stylelint configuration to use the stylelint-stylistic or stylelint-codeguide plugins to restore the deprecated rules instead.

This change was made in [pull request #44: Remove deprecated stylistic rules](alphagov/stylelint-config-gds#44).

Removal of rule enforcing single-colon pseudo elements

We removed the rule selector-pseudo-element-colon-notation preventing double-colon ::before and ::after pseudo elements.

Internet Explorer 8, 9 and 10 require single-colon :before and :after pseudo elements, but supporting these old browsers has not been a requirement for services since June 2018. If you wish to keep support you can configure your Stylelint to re-enable it.

This change was made in [pull request #36: Remove selector-pseudo-element-colon-notation](alphagov/stylelint-config-gds#36).

Commits
  • 5cdee07 Merge pull request #32 from alphagov/stylelint-15
  • 02e3c62 Merge pull request #44 from alphagov/remove-deprecated-stylistic-rules
  • a11aff1 Bump version to 1.0.0
  • bebac04 Add CHANGELOG entry for Stylelint 15
  • b8c402e Update stylelint dependencies for stylelint 15.x
  • ff52d25 Fix moved Stylelint rule documentation URLs
  • b6f49d0 Add CHANGELOG entry for deprecated stylistic rules removal
  • d988cb8 Remove deprecated stylistic rules
  • c5d793e Add CHANGELOG entry for selector-pseudo-element-colon-notation removal
  • 6c17cea Merge pull request #43 from alphagov/dependabot/npm_and_yarn/word-wrap-1.2.4
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) from 0.3.0 to 1.0.0.
- [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md)
- [Commits](alphagov/stylelint-config-gds@0.3.0...1.0.0)

---
updated-dependencies:
- dependency-name: stylelint-config-gds
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Jul 27, 2023
@github-actions
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.


Search page examples to sanity check:

  • https://[HEROKU-APP-ID].herokuapp.com/search/all
  • https://[HEROKU-APP-ID].herokuapp.com/search/research-and-statistics
  • https://[HEROKU-APP-ID].herokuapp.com/search/news-and-communications?parent=%2Feducation&topic=c58fdadd-7743-46d6-9629-90bb3ccc4ef0
  • https://[HEROKU-APP-ID].herokuapp.com/drug-device-alerts
  • https://[HEROKU-APP-ID].herokuapp.com/find-eu-exit-guidance-business
  • https://[HEROKU-APP-ID].herokuapp.com/find-eu-exit-guidance-business?keywords=eori&order=relevance
  • https://[HEROKU-APP-ID].herokuapp.com/find-eu-exit-guidance-business?sector_business_area%5B%5D=aerospace&order=topic
  • https://[HEROKU-APP-ID].herokuapp.com/uk-nationals-living-eu

Other finders

@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3122 July 27, 2023 15:51 Inactive
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3122 July 31, 2023 08:04 Inactive
@JamesCGDS
Copy link
Contributor

JamesCGDS commented Jul 31, 2023

I've pushed up a fix to fix the following errors caused by this dependabot PR:

image

Copy link
Contributor

@gclssvglx gclssvglx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @JamesCGDS 👍

This is going to hit everywhere though 😱

@JamesCGDS JamesCGDS merged commit 47ec145 into main Jul 31, 2023
7 checks passed
@JamesCGDS JamesCGDS deleted the dependabot/npm_and_yarn/stylelint-config-gds-1.0.0 branch July 31, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants