Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Universal Analytics #1812

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Remove Universal Analytics #1812

merged 3 commits into from
Jul 5, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jul 4, 2024

What / Why

Note

There's something called redirect_with_analytics in this repo but it seems backend related, so maybe that's something for a backend dev to sort out? I think it adds cross domain tracking to redirects that comes from govuk_personalisation (see here).

@AshGDS AshGDS self-assigned this Jul 4, 2024
@AshGDS AshGDS force-pushed the remove-ua branch 2 times, most recently from 46ba5e1 to 33071f4 Compare July 4, 2024 14:30
Adds a dummy test to preserve jasmine infrastructure
@AshGDS AshGDS marked this pull request as ready for review July 5, 2024 10:40
@AshGDS AshGDS requested a review from andysellick July 5, 2024 11:04
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AshGDS AshGDS merged commit 0b7cb78 into main Jul 5, 2024
11 checks passed
@AshGDS AshGDS deleted the remove-ua branch July 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants