Skip to content

Commit

Permalink
Remove Slimmer Gem and config
Browse files Browse the repository at this point in the history
- TODO will be addressed in a later commit, for the moment
  just remove all slimmer calls
  • Loading branch information
KludgeKML committed Nov 14, 2024
1 parent 5051406 commit 3a67919
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 19 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ gem "govuk_publishing_components"
gem "jwt"
gem "plek"
gem "ratelimit"
gem "slimmer"
gem "sprockets-rails"
gem "terser"

Expand Down
12 changes: 2 additions & 10 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ GEM
govuk_personalisation (1.0.0)
plek (>= 1.9.0)
rails (>= 6, < 8)
govuk_publishing_components (45.2.0)
govuk_publishing_components (45.3.0)
chartkick
govuk_app_config
govuk_personalisation (>= 0.7.0)
Expand Down Expand Up @@ -461,7 +461,7 @@ GEM
rack (>= 3.0.0)
rack-test (2.1.0)
rack (>= 1.3)
rackup (2.2.0)
rackup (2.2.1)
rack (>= 3)
rails (7.2.2)
actioncable (= 7.2.2)
Expand Down Expand Up @@ -594,13 +594,6 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
slimmer (18.6.2)
json
nokogiri (~> 1.7)
null_logger
plek (>= 1.1.0)
rack (>= 3.0)
rest-client
sprockets (4.2.1)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
Expand Down Expand Up @@ -657,7 +650,6 @@ DEPENDENCIES
rspec-rails
rubocop-govuk
simplecov
slimmer
sprockets-rails
terser
timecop
Expand Down
4 changes: 0 additions & 4 deletions app/controllers/application_controller.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
class ApplicationController < ActionController::Base
include GovukPersonalisation::ControllerConcern

include Slimmer::Template

before_action :set_cache_control_header

# Prevent CSRF attacks by raising an exception.
Expand Down Expand Up @@ -48,8 +46,6 @@ def use_govuk_account_layout?
false
end

slimmer_template :gem_layout

private

def set_cache_control_header
Expand Down
5 changes: 2 additions & 3 deletions app/controllers/subscriptions_management_controller.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class SubscriptionsManagementController < ApplicationController
include Slimmer::Headers
include Slimmer::Template
before_action :handle_one_login_hint, only: [:index]
before_action :require_authentication
before_action :get_subscription_details
Expand Down Expand Up @@ -98,7 +96,8 @@ def confirmed_unsubscribe_all
def use_govuk_account_layout?
@use_govuk_account_layout ||=
if authenticated_via_account?
set_slimmer_headers(template: "gem_layout_account_manager")
# TODO: HERE WE NEED THE ACCOUNT MANAGER LAYOUT
# set_slimmer_headers(template: "gem_layout_account_manager")
true
end
end
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
require File.expand_path("../config/environment", __dir__)
require "rspec/rails"
require "webmock/rspec"
require "slimmer/rspec"
require "gds_api/test_helpers/account_api"
require "gds_api/test_helpers/email_alert_api"

Expand Down

0 comments on commit 3a67919

Please sign in to comment.