Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduled job checking alerts #2026

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Scheduled job checking alerts #2026

merged 5 commits into from
Nov 20, 2023

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Nov 9, 2023 •
edited
Loading

Adds scheduled jobs and workers for Medical Alerts (and eventually Travel Advice Alerts), and prometheus metrics arising from them (these can be compared, if not equal, an alert can be raised)

https://trello.com/c/ONGpFW0k/2258-add-scheduled-job-to-email-alert-api-to-check-delivery-status-of-alert-emails

  • Add tests for Medical Alerts
  • Add tests for Travel Advice Alerts
  • Implement Medical Alert check
  • Implement Travel Advice Alert check

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@KludgeKML KludgeKML force-pushed the scheduled-job-checking-alerts branch 8 times, most recently from 50b6b96 to ae444c7 Compare November 14, 2023 11:31
@KludgeKML KludgeKML marked this pull request as ready for review November 14, 2023 11:40
@KludgeKML KludgeKML force-pushed the scheduled-job-checking-alerts branch 10 times, most recently from 3dbb0ff to 1ab0983 Compare November 16, 2023 15:25
1pretz1
1pretz1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Keith! I've left a few comments, some are consequences of our offline chat (making alert thresholds the same).

lib/search_alert_list.rb Outdated Show resolved Hide resolved
lib/search_alert_list.rb Show resolved Hide resolved
app/workers/medical_safety_alert_check_worker.rb Outdated Show resolved Hide resolved
config/sidekiq.yml Outdated Show resolved Hide resolved
docs/alert_check_scheduled_jobs.md Outdated Show resolved Hide resolved
@KludgeKML KludgeKML force-pushed the scheduled-job-checking-alerts branch 6 times, most recently from e62a1bf to 83961e4 Compare November 20, 2023 11:29
1pretz1
1pretz1 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks good to me! Left two minor comments but non blocking

config/sidekiq.yml Outdated Show resolved Hide resolved
spec/workers/alert_check_worker_spec.rb Outdated Show resolved Hide resolved
@KludgeKML KludgeKML force-pushed the scheduled-job-checking-alerts branch 2 times, most recently from 8b66cb1 to 21c3e65 Compare November 20, 2023 13:25
@KludgeKML KludgeKML merged commit f513e86 into main Nov 20, 2023
4 checks passed
@KludgeKML KludgeKML deleted the scheduled-job-checking-alerts branch November 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pretz1 1pretz1 1pretz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KludgeKML @1pretz1