Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to clear down bad lists #2004

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Add task to clear down bad lists #2004

merged 1 commit into from
Sep 14, 2023

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Sep 13, 2023

Delete bad lists created by accident in April 2023 - these are lists with a specific set of prefixes which have content ids but no tags or links. The subscribers to these lists have all been migrated by the code here: #1948. They'll be deleted automatically, but not for a year, and they're currently causing confusion, so it's best to delete now. The task has been run on integration, is expected to delete about 650 lists.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@KludgeKML KludgeKML force-pushed the bad-list-deletions branch 2 times, most recently from b61d263 to 6c94659 Compare September 14, 2023 08:26
@KludgeKML KludgeKML marked this pull request as ready for review September 14, 2023 08:27
These lists were created by accident in April 2023, the active
subscribers were migrated away from the lists by this PR:
#1948

The lists will delete automatically, but not for a year because
of the one-year retention period for ended subscriptions. In this
case, the data is confusing so worthwhile clearing up earlier.

We won't touch the Subscribers, they'll be retained for a year if
they have no active subscriptions, then cleared up automatically.
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raise message unless valid_prefix?

bad_lists.each do |bad_list|
if bad_list.subscriptions.active.any?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🛡️

@KludgeKML KludgeKML merged commit 966d6ac into main Sep 14, 2023
4 checks passed
@KludgeKML KludgeKML deleted the bad-list-deletions branch September 14, 2023 09:44
@KludgeKML KludgeKML mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants