Allow HistoricDataDeletionWorker to delete Subscribers/SubscriberLists that have older inactive subscriptions. #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that have inactive subscriptions. - add new scope for subscriptions that are either active or ended less than a week ago - add this scope to the selections in the worker so it can delete Subscribers or SubscriberLists if they only contain older ended subscriptions, so they more closely match what the original specs actually asked for. - replace .delete calls with .destroy calls in worker to allow rails to maintain db relation consistency (slower but correct, and worker does not need to be super performant)
|
Closing as I think this will be unnecessary if we simply clear the existing confusing bad lists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/HFy9tpyE/2215-investigate-whether-historic-email-subscription-data-can-be-more-aggressively-deleted