Update to Ruby 3.2.2 #1601
Merged
Update to Ruby 3.2.2 #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaylorgds
force-pushed
the
update-to-ruby-3.2.2
branch
from
5351a0b to
45f7086
Compare
There has been a change in how Ruby prints errors, which seems to have impacted a test that was checking stdout. The Ruby change discussion talks about printing unhandled errors, and in our case we're printing the results of an exception's `#inspect` method in a `rescue` block, but it seems too closely-related to be a coincidence. Aside from making the output go all on a single line (so the newlines in the HEREDOC were being removed), the escape sequences were being double-escaped (so every `\"` became `\\"`). Putting single-quotes around the opening identifier avoids this issue. Ruby language change discussion: https://bugs.ruby-lang.org/issues/18367
mtaylorgds
force-pushed
the
update-to-ruby-3.2.2
branch
from
45f7086 to
830c6cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a change in how Ruby prints errors, which seems to have impacted a test that was checking stdout. The Ruby change discussion talks about printing unhandled errors, and in our case we're printing the results of an exception's
#inspectmethod in arescueblock, but it seems too closely-related to be a coincidence.Aside from making the output go all on a single line (so the newlines in the HEREDOC were being removed), the escape sequences were being double-escaped (so every
\"became\\"). Putting single-quotes around the opening identifier avoids this issue.Ruby language change discussion:
https://bugs.ruby-lang.org/issues/18367
Trello card