Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GraphQL for rendering Role page #3845

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use GraphQL for rendering Role page #3845

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1900795
Swap instance variable for local
mike3985 Nov 11, 2024
325b099
Move Role's presentation into a presenter
mike3985 Nov 11, 2024
d601808
Introduce Role page feature spec
mike3985 Nov 11, 2024
db64da0
Define sub-presenters for Role's links
mike3985 Nov 12, 2024
e796d5c
Add Graphql query for Role
mike3985 Nov 12, 2024
ebfb868
Add prime-minister role test fixture
mike3985 Nov 11, 2024
4f05e86
Introduce a Graphql-specific Role model
mike3985 Nov 12, 2024
1d843cc
Introduce a GraphQL-specific Role presenter
mike3985 Nov 12, 2024
46cc139
Check for GraphQL feature flag in Roles controller
mike3985 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/models/role_graphql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
class RoleGraphql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this (and the other for the world index) should be namespaced to keep them all together in one place? E.g. Graphql::Role?

attr_reader :content_item

def initialize(content_item)
@content_item = content_item
end

def self.find!(base_path)
query = Graphql::RoleQuery.new(base_path).query

edition = Services.publishing_api.graphql_query(query).dig("data", "edition")
new(edition)
end
end