Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taxon-list component #3844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Nov 12, 2024

What

  • Remove all files relating to the taxon-list component
  • heading_level variable removed from the _tagged_content_list.html.erb template, a custom heading level is not currently used anywhere, the default heading level used by the taxon-list component was h2
  • Use the list component from the gem instead of the taxon-list app component in several view templates where required
    • list_type: "number" has been used to ensure an ordered list is used to match the current HTML structure

Why

This component is no longer required, it was originally created for an AB Test on https://www.gov.uk/education/funding-and-finance-for-students#/education/student-grants-bursaries-scholarships

The same design can be achieved using the list component from the govuk-publishing-components gem

Visual changes

There are no visual changes, the HTML structure and spacing is the same as before

Example pages

Trello card

Remove all files relating to the taxon-list component the taxon-list component as it is no longer required.

The component was originally created for an AB Test on https://www.gov.uk/education/funding-and-finance-for-students#/education/student-grants-bursaries-scholarships

This page is now using the document-list component from the govuk_publishing_components gem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants